Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Convert some loops to range-based #4485

Merged
merged 4 commits into from
Feb 20, 2024
Merged

[all] Convert some loops to range-based #4485

merged 4 commits into from
Feb 20, 2024

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 7, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

fredroy
fredroy requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "indice" thing to replace with "index" appears multiple times (I just highlighted one...)

Sofa/Component/IO/Mesh/src/sofa/component/io/mesh/STLExporter.cpp Outdated Show resolved Hide resolved
...Constraint/Projective/src/sofa/component/constraint/projective/FixedProjectiveConstraint.cpp Outdated Show resolved Hide resolved
@alxbilger alxbilger requested a review from fredroy February 15, 2024 09:03
@bakpaul
Copy link
Contributor

bakpaul commented Feb 15, 2024

[ci-build][with-all-tests][force-full-build]

@bakpaul
Copy link
Contributor

bakpaul commented Feb 15, 2024

[ci-build][with-all-tests]

fredroy
fredroy requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UniformMass still uses indice 😅

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 20, 2024
@fredroy fredroy merged commit 2f6c22e into sofa-framework:master Feb 20, 2024
15 checks passed
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
3 participants
@alxbilger @bakpaul @fredroy